[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RfC PATCH 10/10] vnc-jobs: move buffer reset, use new
From: |
Peter Lieven |
Subject: |
Re: [Qemu-devel] [RfC PATCH 10/10] vnc-jobs: move buffer reset, use new buffer move |
Date: |
Fri, 25 Sep 2015 11:39:17 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
Am 24.09.2015 um 10:42 schrieb Gerd Hoffmann:
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
> ui/vnc-jobs.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/ui/vnc-jobs.c b/ui/vnc-jobs.c
> index 50e6b37..dfc5139 100644
> --- a/ui/vnc-jobs.c
> +++ b/ui/vnc-jobs.c
> @@ -165,8 +165,7 @@ void vnc_jobs_consume_buffer(VncState *vs)
>
> vnc_lock_output(vs);
> if (vs->jobs_buffer.offset) {
> - vnc_write(vs, vs->jobs_buffer.buffer, vs->jobs_buffer.offset);
> - qio_buffer_reset(&vs->jobs_buffer);
> + qio_buffer_move(&vs->output, &vs->jobs_buffer);
vnc_write restores the output handler. you need to add:
diff --git a/ui/vnc-jobs.c b/ui/vnc-jobs.c
index dfc5139..07e0445 100644
--- a/ui/vnc-jobs.c
+++ b/ui/vnc-jobs.c
@@ -29,6 +29,7 @@
#include "vnc.h"
#include "vnc-jobs.h"
#include "qemu/sockets.h"
+#include "qemu/main-loop.h"
#include "block/aio.h"
/*
@@ -165,6 +166,9 @@ void vnc_jobs_consume_buffer(VncState *vs)
vnc_lock_output(vs);
if (vs->jobs_buffer.offset) {
+ if (qio_buffer_empty(&vs->output)) {
+ qemu_set_fd_handler(vs->csock, vnc_client_read, vnc_client_write,
vs);
+ }
qio_buffer_move(&vs->output, &vs->jobs_buffer);
}
flush = vs->csock != -1 && vs->abort != true;
or you get ocasional hangs.
Peter
- [Qemu-devel] [RfC PATCH 09/10] vnc: kill jobs queue buffer, (continued)
- [Qemu-devel] [RfC PATCH 09/10] vnc: kill jobs queue buffer, Gerd Hoffmann, 2015/09/24
- [Qemu-devel] [RfC PATCH 07/10] io: add qio_buffer tracing, Gerd Hoffmann, 2015/09/24
- [Qemu-devel] [RfC PATCH 08/10] name vnc buffers, Gerd Hoffmann, 2015/09/24
- [Qemu-devel] [RfC PATCH 05/10] io: add qio_buffer_move_empty, Gerd Hoffmann, 2015/09/24
- [Qemu-devel] [RfC PATCH 10/10] vnc-jobs: move buffer reset, use new buffer move, Gerd Hoffmann, 2015/09/24
- Re: [Qemu-devel] [RfC PATCH 10/10] vnc-jobs: move buffer reset, use new buffer move,
Peter Lieven <=
- [Qemu-devel] [RfC PATCH 02/10] io: pull Buffer code out of VNC module, Gerd Hoffmann, 2015/09/24
- Re: [Qemu-devel] [RfC PATCH 00/10] vnc buffer handling, Daniel P. Berrange, 2015/09/24
- Re: [Qemu-devel] [RfC PATCH 00/10] vnc buffer handling, Peter Lieven, 2015/09/25