Re: [Qemu-devel] [v4][PATCH 0/2] libxl: try to support IGD passthrough for qemu upstream

[Chen, Tiejun]

Ping...

Thanks
Tiejun

On 9/18/2015 4:30 PM, Tiejun Chen wrote:
> Ian,
>
> As we discussed previously,
>
> http://patchwork.ozlabs.org/patch/457055/
>
> now it's time to push this into on xen/tools side since all qemu stuffs
> have been merged.
>
> https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg02094.html
>
> v4:
>
> Ian,
>
> Actually we had v3.5 online previously, which was reviewed by you.
>
> http://permalink.gmane.org/gmane.comp.emulators.qemu/329100
>
> So here I just bring a little bit to refine code just for patch #2
> according to out last conversation.
>
> v3:
>
> * Refine some codes based on Campbell's feedback so thanks for Campbell's
>    kind guideline to patch #2
> * Update the manpages in patch #2
>
> v2:
>
> * Refine patch #2's head description
> * Improve codes quality inside patch #1 based on Wei's comments
> * Refill the summary inside patch #0 based on Konrad and Wei's suggestion
>
> When we're working to support IGD GFX passthrough with qemu
> upstream, instead of "-gfx_passthru" we'd like to make that
> a machine option, "-machine xxx,igd-passthru=on".
>
> https://lists.nongnu.org/archive/html/qemu-devel/2015-01/msg02050.html
>
> This need to bring a change on tool side.
>
> After a discussion with Campbell, we'd like to construct a table to record
> all IGD devices we can support. If we hit that table, we should pass that
> option. And so we also introduce a new field of type, 'gfx_passthru_kind',
> to cooperate with 'gfx_passthru' to cover all scenarios like this,
>
>      gfx_passthru = 0    => sets build_info.u.gfx_passthru to false
>      gfx_passthru = 1    => sets build_info.u.gfx_passthru to true and
>                             build_info.u.gfx_passthru_kind to DEFAULT
>      gfx_passthru = "igd"    => sets build_info.u.gfx_passthru to false
>                                 and build_info.u.gfx_passthru_kind to IGD
>
> And note actually that option "-gfx_passthru" is just introduced to
> work for qemu-xen-traditional so we should get this away from
> libxl__build_device_model_args_new() in the case of qemu upstream.
>
> ----------------------------------------------------------------
> Tiejun Chen (2):
>        libxl: introduce libxl__is_igd_vga_passthru
>        libxl: introduce gfx_passthru_kind
>
>   docs/man/xl.cfg.pod.5        |  35 ++++++++--
>   tools/libxl/libxl.h          |   6 ++
>   tools/libxl/libxl_dm.c       |  46 +++++++++++--
>   tools/libxl/libxl_internal.h |   2 +
>   tools/libxl/libxl_pci.c      | 124 +++++++++++++++++++++++++++++++++++
>   tools/libxl/libxl_types.idl  |   6 ++
>   tools/libxl/xl_cmdimpl.c     |  14 +++-
>   7 files changed, 223 insertions(+), 10 deletions(-)
>
> Thanks
> Tiejun