[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] linux-user: Use g_new() & friends where that ma
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH] linux-user: Use g_new() & friends where that makes obvious sense |
Date: |
Thu, 24 Sep 2015 18:19:48 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Stefan Weil <address@hidden> writes:
> Am 24.09.2015 um 09:06 schrieb Markus Armbruster:
>> Ping?
>>
>> Markus Armbruster <address@hidden> writes:
>>
>>> g_new(T, n) is neater than g_malloc(sizeof(T) * n). It's also
>>> safer, for two reasons. One, it catches multiplication
>>> overflowing size_t. Two, it returns T * rather than void *,
>>> which lets the compiler catch more type errors.
>>>
>>> This commit only touches allocations with size arguments of the
>>> form sizeof(T). Same Coccinelle semantic patchas in commit
>>> b45c03f.
>>>
>>> Signed-off-by: Markus Armbruster <address@hidden> ---
>>> linux-user/elfload.c | 2 +- linux-user/main.c | 2 +-
>>> linux-user/syscall.c | 2 +- 3 files changed, 3 insertions(+), 3
>>> deletions(-)
>
> Reviewed-by: Stefan Weil <address@hidden>
>
> This patch is trivial enough for qemu-trivial.
I guess it is. For code with a maintainer, I tend to try the maintainer
first.
> As Eric has written, the commit message needs
> a small correction: s/patchas/patch as/
Yes.