[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 14/16] blockjob: Store device name at job creati
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH 14/16] blockjob: Store device name at job creation |
Date: |
Wed, 23 Sep 2015 18:46:13 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 17.09.2015 15:48, Kevin Wolf wrote:
> Some block jobs change the block device graph on completion. This means
> that the device that owns the job and originally was addressed with its
> device name may no longer be what the corresponding BlockBackend points
> to.
>
> Previously, the effects of bdrv_swap() ensured that the job was (at
> least partially) transferred to the target image. Events that contain
> the device name could still use bdrv_get_device_name(job->bs) and get
> the same result.
>
> After removing bdrv_swap(), this won't work any more. Instead, save the
> device name at job creation and use that copy for the events.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> blockjob.c | 8 +++++---
> include/block/blockjob.h | 8 ++++++++
> 2 files changed, 13 insertions(+), 3 deletions(-)
Why not %s/bdrv_get_device_name(job->bs)/job->id/?
Max
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 08/16] block: Manage backing file references in bdrv_set_backing_hd(), (continued)
- [Qemu-devel] [PATCH 10/16] block/io: Make bdrv_requests_pending() public, Kevin Wolf, 2015/09/17
- [Qemu-devel] [PATCH 11/16] block-backend: Add blk_set_bs(), Kevin Wolf, 2015/09/17
- [Qemu-devel] [PATCH 07/16] block: Convert bs->backing_hd to BdrvChild, Kevin Wolf, 2015/09/17
- [Qemu-devel] [PATCH 14/16] blockjob: Store device name at job creation, Kevin Wolf, 2015/09/17
- Re: [Qemu-devel] [PATCH 14/16] blockjob: Store device name at job creation,
Max Reitz <=
- [Qemu-devel] [PATCH 13/16] block: Implement bdrv_append() without bdrv_swap(), Kevin Wolf, 2015/09/17
- Re: [Qemu-devel] [PATCH 13/16] block: Implement bdrv_append() without bdrv_swap(), Max Reitz, 2015/09/23
[Qemu-devel] [PATCH 12/16] block: Introduce parents list, Kevin Wolf, 2015/09/17
[Qemu-devel] [PATCH 15/16] block: Add and use bdrv_replace_in_backing_chain(), Kevin Wolf, 2015/09/17