[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PULL 2/8] hmp: Allow for error message hi
From: |
John Snow |
Subject: |
Re: [Qemu-devel] [Qemu-block] [PULL 2/8] hmp: Allow for error message hints on HMP |
Date: |
Tue, 22 Sep 2015 19:02:10 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 09/22/2015 01:02 PM, Eric Blake wrote:
> On 09/22/2015 09:23 AM, Kevin Wolf wrote:
>> Am 18.09.2015 um 15:22 hat Markus Armbruster geschrieben:
>>> From: Eric Blake <address@hidden>
>>>
>>> Commits 7216ae3d and d2828429 disabled some error message hints,
>>> all because a change to use modern error reporting meant that the
>>> hint would be output prior to the actual error. Fix this by making
>>> hints a first-class member of Error.
>>>
>>> For example, we are now back to the pleasant:
>>>
>>> $ qemu-system-x86_64 --nodefaults -S --vnc :0 --chardev null,id=,
>>> qemu-system-x86_64: --chardev null,id=,: Parameter 'id' expects an
>>> identifier
>>> Identifiers consist of letters, digits, '-', '.', '_', starting with a
>>> letter.
>>>
>>> Signed-off-by: Eric Blake <address@hidden>
>>> Reviewed-by: Paolo Bonzini <address@hidden>
>>> Message-Id: <address@hidden>
>>> Signed-off-by: Markus Armbruster <address@hidden>
>>
>> This broke qemu-iotests 049. Can you please send a patch to update the
>> reference output?
>
> Will do (and I guess I should run qemu-iotests more frequently. Does
> 'make check' suffice, or is there other magic involved?)
>
>From the build directory:
pushd tests/qemu-iotests;
./check -v -qcow2;
./check -v -raw;
popd
If there is a smarter way of doing it, it is unknown to me.
--js
- [Qemu-devel] [PULL 0/8] Error reporting patches, Markus Armbruster, 2015/09/18
- [Qemu-devel] [PULL 4/8] MAINTAINERS: Add "Error reporting" entry, Markus Armbruster, 2015/09/18
- [Qemu-devel] [PULL 3/8] error: Copy location information in error_copy(), Markus Armbruster, 2015/09/18
- [Qemu-devel] [PULL 1/8] error: only prepend timestamp on stderr, Markus Armbruster, 2015/09/18
- [Qemu-devel] [PULL 7/8] loader: Fix memory_region_init_resizeable_ram() error handling, Markus Armbruster, 2015/09/18
- [Qemu-devel] [PULL 2/8] hmp: Allow for error message hints on HMP, Markus Armbruster, 2015/09/18
- [Qemu-devel] [PULL 5/8] error: New error_fatal, Markus Armbruster, 2015/09/18
- [Qemu-devel] [PULL 8/8] memory: Fix bad error handling in memory_region_init_ram_ptr(), Markus Armbruster, 2015/09/18
- [Qemu-devel] [PULL 6/8] Fix bad error handling after memory_region_init_ram(), Markus Armbruster, 2015/09/18
- Re: [Qemu-devel] [PULL 0/8] Error reporting patches, Peter Maydell, 2015/09/18