qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] ui/cocoa.m: remove open dialog code


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH] ui/cocoa.m: remove open dialog code
Date: Mon, 21 Sep 2015 12:01:26 -0700

On 19 September 2015 at 08:01, Programmingkid <address@hidden> wrote:
>
> On Sep 19, 2015, at 10:58 AM, Peter Maydell wrote:
>> By the way, I don't mean that I'm completely opposed to the
>> idea of dropping the open-dialog. I'd just like to hear
>> some input from other people who care about OSX QEMU
>> rather than just you and me.
>
> Who else is there?

Andreas had some feedback on IRC.

I've thought about this a bit and:

(1) this "open-dialog if no command line arguments" is really QEMU
trying to provide features that ought to be in a virt-manager
type wrapper, not in QEMU proper. So that's one argument for
dropping it. A proper wrapper VM manager program would obviously
launch its VM management GUI window if started via the GUI (or
would have VM config files that it would associate to itself and
run if the files were clicked).

(2) Dropping the dialog box brings the OSX UI code closer into
line with the other UI frontends. That means that at some point
in the future we could maybe restructure it so it doesn't have
the weird "UI's main function takes control at startup" structure,
and we can just init the UI in the same way the other UIs do.

(3) if we don't drop it, we should probably only have it when
we don't see the magic argument that means "we got invoked by
somebody double-clicking the app in Finder".

Currently I'm leaning towards "yes, just drop the dialog box
completely".

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]