[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/6] hw/s390x/css: Use type_init() instead of ma
From: |
Christian Borntraeger |
Subject: |
Re: [Qemu-devel] [PATCH 2/6] hw/s390x/css: Use type_init() instead of machine_init() |
Date: |
Mon, 21 Sep 2015 10:04:18 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
Am 19.09.2015 um 17:36 schrieb Andreas Färber:
> Here, machine_init() is being misused to initialize global variables.
> Being all local, it's safe to use the slightly earlier type_init().
>
> This prepares for dropping machine_init().
>
> Signed-off-by: Andreas Färber <address@hidden>
Acked-by: Christian Borntraeger <address@hidden>
I think this should go via your tree to coordinate with machine_init removal.
> ---
> hw/s390x/css.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/s390x/css.c b/hw/s390x/css.c
> index c033612..d164fa8 100644
> --- a/hw/s390x/css.c
> +++ b/hw/s390x/css.c
> @@ -1509,7 +1509,7 @@ static void css_init(void)
> channel_subsys->chnmon_active = false;
> QTAILQ_INIT(&channel_subsys->io_adapters);
> }
> -machine_init(css_init);
> +type_init(css_init)
>
> void css_reset_sch(SubchDev *sch)
> {
>
- [Qemu-devel] [PATCH 0/6] machine: Deprecate machine_init(), Andreas Färber, 2015/09/19
- [Qemu-devel] [PATCH 3/6] Introduce config_init() for QemuOpts, Andreas Färber, 2015/09/19
- [Qemu-devel] [PATCH 4/6] Drop machine_init() and MODULE_INIT_MACHINE, Andreas Färber, 2015/09/19
- [Qemu-devel] [PATCH 2/6] hw/s390x/css: Use type_init() instead of machine_init(), Andreas Färber, 2015/09/19
- Re: [Qemu-devel] [PATCH 2/6] hw/s390x/css: Use type_init() instead of machine_init(),
Christian Borntraeger <=
- [Qemu-devel] [PATCH 6/6] pc: Use type_register_static() for machine types, Andreas Färber, 2015/09/19
- [Qemu-devel] [PATCH 1/6] Use type_init() for all machine QOM types, Andreas Färber, 2015/09/19
- [Qemu-devel] [PATCH 5/6] exynos4: Further QOM'ify machines, Andreas Färber, 2015/09/19
- Re: [Qemu-devel] [PATCH 0/6] machine: Deprecate machine_init(), Eduardo Habkost, 2015/09/21