[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/4] hmp-commands-info: move info_cmds content o
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 1/4] hmp-commands-info: move info_cmds content out of monitor.c |
Date: |
Fri, 18 Sep 2015 17:20:12 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 18/09/2015 17:12, Markus Armbruster wrote:
> "Denis V. Lunev" <address@hidden> writes:
>
>> From: Pavel Butsykin <address@hidden>
>>
>> For moving target- and device-specific code from monitor.c,
>> to beginning we move info_cmds content to hmp-commands-info.hx
>>
>> Signed-off-by: Pavel Butsykin <address@hidden>
>> Signed-off-by: Denis V. Lunev <address@hidden>
>> CC: Paolo Bonzini <address@hidden>
>> CC: Peter Maydell <address@hidden>
>
> For me, this commit drops "info pci".
>
> Before:
>
> $ qemu-system-x86_64 -nodefaults -S -display none -monitor stdio
> QEMU 2.4.50 monitor - type 'help' for more information
> (qemu) info pci
> Bus 0, device 0, function 0:
> Host bridge: PCI device 8086:1237
> id ""
> Bus 0, device 1, function 0:
> ISA bridge: PCI device 8086:7000
> id ""
> Bus 0, device 1, function 1:
> IDE controller: PCI device 8086:7010
> BAR4: I/O at 0xffffffffffffffff [0x000e].
> id ""
> Bus 0, device 1, function 3:
> Bridge: PCI device 8086:7113
> IRQ 0.
> id ""
>
> After:
>
> (qemu) info pci
> unknown command: 'pci'
>
> Please advise.
s/advise/fix/... patch sent. Let me know who shall send it to Peter.
(BTW, it's obvious that I don't scale to 100+ patches per month. Do you
still have that script of yours looking for unmaintained areas?).
Paolo
- [Qemu-devel] [PATCH v4 0/4] Move target- and device specific code from monitor, Denis V. Lunev, 2015/09/10
- [Qemu-devel] [PATCH 3/4] hmp-commands.hx: fix end of table info, Denis V. Lunev, 2015/09/10
- [Qemu-devel] [PATCH 4/4] monitor: added generation of documentation for hmp-commands-info.hx, Denis V. Lunev, 2015/09/10
- [Qemu-devel] [PATCH 1/4] hmp-commands-info: move info_cmds content out of monitor.c, Denis V. Lunev, 2015/09/10
- Re: [Qemu-devel] [PATCH 1/4] hmp-commands-info: move info_cmds content out of monitor.c, Markus Armbruster, 2015/09/18
- [Qemu-devel] [PATCH] hmp-commands-info.hx: fix drops hmp "info pci", Pavel Butsykin, 2015/09/18
- Re: [Qemu-devel] [PATCH] hmp-commands-info.hx: fix drops hmp "info pci", Eric Blake, 2015/09/18
- Re: [Qemu-devel] [PATCH] hmp-commands-info.hx: fix drops hmp "info pci", Pavel Butsykin, 2015/09/18
- Re: [Qemu-devel] [PATCH] hmp-commands-info.hx: fix drops hmp "info pci", Markus Armbruster, 2015/09/21
- Re: [Qemu-devel] [PATCH] hmp-commands-info.hx: fix drops hmp "info pci", Paolo Bonzini, 2015/09/21
- Re: [Qemu-devel] [PATCH] hmp-commands-info.hx: fix drops hmp "info pci", Markus Armbruster, 2015/09/21
[Qemu-devel] [PATCH 2/4] monitor: remove target-specific code from monitor.c, Denis V. Lunev, 2015/09/10
Re: [Qemu-devel] [PATCH v4 0/4] Move target- and device specific code from monitor, Peter Crosthwaite, 2015/09/10