[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/4] tests: add some qemu_strtosz() tests
From: |
Marc-André Lureau |
Subject: |
Re: [Qemu-devel] [PATCH v2 2/4] tests: add some qemu_strtosz() tests |
Date: |
Fri, 18 Sep 2015 11:10:49 -0400 (EDT) |
Hi
----- Original Message -----
> On 09/18/2015 04:59 AM, address@hidden wrote:
> > From: Marc-André Lureau <address@hidden>
> >
> > While reading the function I decided to write some tests.
> >
> > Signed-off-by: Marc-André Lureau <address@hidden>
> > Reviewed-by: Eric Blake <address@hidden>
> > ---
> > tests/test-cutils.c | 91
> > +++++++++++++++++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 91 insertions(+)
>
> I accepted v1 because it was better than no tests at all, but did make
> some suggestions for additional tests to perform. I'm surprised you
> didn't include any of those suggestions in v2. For example, it would be
> nice if the testsuite documents a contract on what happens with a bogus
> suffix: is "1234x" outright rejected, or does it parse as "1234" leaving
> the pointer at 'x'?
I thought you were ok with this patch as is. But I can add some failing tests
if you want (although it feels like testing strtod() at this point.