[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/4] checkpatch: adapt some tests to QEMU
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH 3/4] checkpatch: adapt some tests to QEMU |
|
Date: |
Thu, 17 Sep 2015 10:44:40 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 09/17/2015 10:32 AM, Paolo Bonzini wrote:
>>>> Can we revert this one, please? Checkpatch now warns about constructs
>>>> like
>>>> typedef struct MyDevice {
>>>> DeviceState parent;
>>>>
>>>> int reg0, reg1, reg2;
>>>> } MyDevice;
>>>
>>> It's interesting that qom/object.h documents this and start like:
>>>
>>> typedef struct ObjectClass ObjectClass;
> I think it varies depending on the maintainer. PPC, USB, SCSI, ACPI all
> use a separate typedef. I'll prepare a revert.
And qapi is about to switch from inline to separate:
https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg04291.html
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 2/4] CODING_STYLE, checkpatch: update line length rules, (continued)
[Qemu-devel] [PATCH 3/4] checkpatch: adapt some tests to QEMU, Paolo Bonzini, 2015/09/07
[Qemu-devel] [PATCH 4/4] checkpatch: remove tests that are not relevant outside the kernel, Paolo Bonzini, 2015/09/07