[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] vmdk: Create streamOptimized as version 3
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH] vmdk: Create streamOptimized as version 3 |
Date: |
Thu, 17 Sep 2015 10:55:55 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 17.09.2015 um 07:04 hat Fam Zheng geschrieben:
> VMware products accept only version 3 for streamOptimized, let's bump
> the version.
>
> Reported-by: Radoslav Gerganov <address@hidden>
> Signed-off-by: Fam Zheng <address@hidden>
Radoslav, can I have your Reviewed-by and/or Tested-by for this patch?
Kevin
> block/vmdk.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/block/vmdk.c b/block/vmdk.c
> index be0d640..37326c3 100644
> --- a/block/vmdk.c
> +++ b/block/vmdk.c
> @@ -1651,7 +1651,13 @@ static int vmdk_create_extent(const char *filename,
> int64_t filesize,
> }
> magic = cpu_to_be32(VMDK4_MAGIC);
> memset(&header, 0, sizeof(header));
> - header.version = zeroed_grain ? 2 : 1;
> + if (compress) {
> + header.version = 3;
> + } else if (zeroed_grain) {
> + header.version = 2;
> + } else {
> + header.version = 1;
> + }
> header.flags = VMDK4_FLAG_RGD | VMDK4_FLAG_NL_DETECT
> | (compress ? VMDK4_FLAG_COMPRESS | VMDK4_FLAG_MARKER : 0)
> | (zeroed_grain ? VMDK4_FLAG_ZERO_GRAIN : 0);
> --
> 2.4.3
>