qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v1 2/2] qemu-nbd: convert to use the QAPI Socket


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH v1 2/2] qemu-nbd: convert to use the QAPI SocketAddress object
Date: Wed, 16 Sep 2015 16:23:39 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0


On 16/09/2015 16:13, Daniel P. Berrange wrote:
> > The qapi type is gross for requiring port as a string. But we have plans
> > to clean that up, not a showstopper for this patch.
>
> On the contrary - QAPI is correct in requiring this, as it lets you
> provide a service name (as defined in /etc/services) instead of a
> numeric port, and getaddrinfo() will look that up and convert to
> numeric format.

Was going to say the same. :)  I'll fix up patch 1 and apply both.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]