[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/7] net: remove NetLegacy struct
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 3/7] net: remove NetLegacy struct |
Date: |
Tue, 15 Sep 2015 08:54:14 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 09/07/2015 06:08 AM, Kővágó, Zoltán wrote:
> NetLegacy is just Netdev with some extra fields (name, vlan) and an
> optional id. This patch merges the two structs, and net_client_init1
> got some extra checks to make sure only accept valid -netdev command
> lines. This is some extra work, but allows us to uniformly manage both
> legacy -net and non-legacy -netdev in code.
>
> Signed-off-by: Kővágó, Zoltán <address@hidden>
> ---
> net/net.c | 42 +++++++++++++++++++++---------------------
> qapi-schema.json | 30 +++++++++---------------------
> 2 files changed, 30 insertions(+), 42 deletions(-)
I'm still not a fan of this one. See my counter-proposal that rewrites
patches 4/7 and 5/7 of this series to keep NetdevLegacy a separate type
for command line usage, while exposing only Netdev through QMP (in
particular, patch 2/29 and 27/29 are my rewrites, and 29/29 turns on
Netdev use in QMP)
https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg02580.html
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 0/7] qapi-flattening and preparation of -audiodev option, Kővágó, Zoltán, 2015/09/07
- [Qemu-devel] [PATCH 1/7] qapi: support implicit structs in OptsVisitor, Kővágó, Zoltán, 2015/09/07
- [Qemu-devel] [PATCH 2/7] qapi: convert NumaOptions into a flat union, Kővágó, Zoltán, 2015/09/07
- [Qemu-devel] [PATCH 3/7] net: remove NetLegacy struct, Kővágó, Zoltán, 2015/09/07
- Re: [Qemu-devel] [PATCH 3/7] net: remove NetLegacy struct,
Eric Blake <=
- [Qemu-devel] [PATCH 6/7] qapi: reorder NetdevBase and Netdev, Kővágó, Zoltán, 2015/09/07
- [Qemu-devel] [PATCH 4/7] net: use Netdev instead of NetClientOptions in client init, Kővágó, Zoltán, 2015/09/07
- [Qemu-devel] [PATCH 7/7] qapi: support nested structs in OptsVisitor, Kővágó, Zoltán, 2015/09/07
- [Qemu-devel] [PATCH 5/7] qapi: change Netdev into a flat union, Kővágó, Zoltán, 2015/09/07
- Re: [Qemu-devel] [PATCH 0/7] qapi-flattening and preparation of -audiodev option, Markus Armbruster, 2015/09/14