qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v7 18/26] qapi-commands: De-duplicate output mar


From: Daniel P. Berrange
Subject: Re: [Qemu-devel] [PATCH v7 18/26] qapi-commands: De-duplicate output marshaling functions
Date: Tue, 15 Sep 2015 12:10:04 +0100
User-agent: Mutt/1.5.23 (2014-03-12)

On Mon, Sep 14, 2015 at 07:57:49PM +0200, Markus Armbruster wrote:
> gen_marshal_output() uses its parameter name only for name of the
> generated function.  Name it after the type being marshaled instead of
> its caller, and drop duplicates.
> 
> Saves 7 copies of qmp_marshal_output_int() in qemu-ga, and one copy of
> qmp_marshal_output_str() in qemu-system-*.
> 
> Signed-off-by: Markus Armbruster <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> ---
>  docs/qapi-code-gen.txt   |  4 ++--
>  scripts/qapi-commands.py | 17 ++++++++++-------
>  2 files changed, 12 insertions(+), 9 deletions(-)

Reviewed-by: Daniel P. Berrange <address@hidden>

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|



reply via email to

[Prev in Thread] Current Thread [Next in Thread]