[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 18/26] qapi-commands: De-duplicate output mar
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH v7 18/26] qapi-commands: De-duplicate output marshaling functions |
Date: |
Tue, 15 Sep 2015 12:10:04 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Mon, Sep 14, 2015 at 07:57:49PM +0200, Markus Armbruster wrote:
> gen_marshal_output() uses its parameter name only for name of the
> generated function. Name it after the type being marshaled instead of
> its caller, and drop duplicates.
>
> Saves 7 copies of qmp_marshal_output_int() in qemu-ga, and one copy of
> qmp_marshal_output_str() in qemu-system-*.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> ---
> docs/qapi-code-gen.txt | 4 ++--
> scripts/qapi-commands.py | 17 ++++++++++-------
> 2 files changed, 12 insertions(+), 9 deletions(-)
Reviewed-by: Daniel P. Berrange <address@hidden>
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
- Re: [Qemu-devel] [PATCH v7 13/26] qapi: Clean up after recent conversions to QAPISchemaVisitor, (continued)
- [Qemu-devel] [PATCH v7 24/26] qapi: Pseudo-type '**' is now unused, drop it, Markus Armbruster, 2015/09/14
- [Qemu-devel] [PATCH v7 15/26] qapi-commands: Rearrange code, Markus Armbruster, 2015/09/14
- [Qemu-devel] [PATCH v7 26/26] qapi-introspect: Hide type names, Markus Armbruster, 2015/09/14
- [Qemu-devel] [PATCH v7 21/26] qapi: Introduce a first class 'any' type, Markus Armbruster, 2015/09/14
- [Qemu-devel] [PATCH v7 18/26] qapi-commands: De-duplicate output marshaling functions, Markus Armbruster, 2015/09/14
- Re: [Qemu-devel] [PATCH v7 18/26] qapi-commands: De-duplicate output marshaling functions,
Daniel P. Berrange <=
- [Qemu-devel] [PATCH v7 16/26] qapi: Rename qmp_marshal_input_FOO() to qmp_marshal_FOO(), Markus Armbruster, 2015/09/14
- [Qemu-devel] [PATCH v7 25/26] qapi: New QMP command query-qmp-schema for QMP introspection, Markus Armbruster, 2015/09/14
- Re: [Qemu-devel] [PATCH v7 00/26] qapi: QMP introspection, Markus Armbruster, 2015/09/15