Re: [Qemu-devel] [RFC PATCH 1/2] target-ppc: remove hreg_compute_mem_idx() from cpu_post_load

[Alexey Kardashevskiy]

On 09/15/2015 05:30 AM, Mark Cave-Ayland wrote:
> hreg_compute_mem_idx() has already been called previously by ppc_store_msr()
> via hreg_store_msr() and hreg_compute_hflags(). Drop the duplicate function
> call as it is no longer needed.
>
> Signed-off-by: Mark Cave-Ayland <address@hidden>

Reviewed-by: Alexey Kardashevskiy <address@hidden>        

> ---
>   target-ppc/machine.c |    2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/target-ppc/machine.c b/target-ppc/machine.c
> index f4ac761..bd99844 100644
> --- a/target-ppc/machine.c
> +++ b/target-ppc/machine.c
> @@ -197,8 +197,6 @@ static int cpu_post_load(void *opaque, int version_id)
>       env->msr ^= ~((1ULL << MSR_TGPR) | MSR_HVB);
>       ppc_store_msr(env, msr);
>
> -    hreg_compute_mem_idx(env);
> -
>       return 0;
>   }


--
Alexey