Re: [Qemu-devel] [PATCH v10 00/10] Add a netfilter object and netbuffer filter

[Daniel P. Berrange]

On Mon, Sep 14, 2015 at 01:09:25PM +0800, Yang Hongyang wrote:
> Hi Stefan,Jason,
> 
> I've convert this series to base on QOM, and introducing NetQueue apis
> instead of using Netqueue internals as Stefan suggested. Could you please 
> take a
> look at it?

I won't look at the actual net filtering stuff since that's not my area
of expertize. I looked at the QOM related patches and that stuff all looks
good to me, with a few small nitpicks.

> Most of the details have been reviewed by Jason, and the whole filter logic
> isn't changed.
> One missing feature compared to previous versions is the multiqueue support,
> however, I've already implemented it, before sending it out, I need to get as
> many review comments as possible on this series, and addressing it, in order 
> to
> reduce the iter round...And multiqueue support can be sent later as a seperate
> series if the base can go in first. If there has to be another few rounds, I
> will include multiqueue patches.


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|