[Qemu-devel] [RFC PATCH 0/3] adding acpi node for fw_cfg on pc and arm

[Gabriel L. Somlo]

This series adds a fw_cfg device node to the SSDT (on pc), or to the
DSDT (on arm).

        - Patch 1/3 moves (and renames) the BIOS_CFG_IOPORT (0x510)
          define from pc.c to pc.h, so that it could be used from
          acpi-build.c in patch 2/3.

        - Patch 2/3 adds a fw_cfg node to the pc SSDT.

        - Patch 3/3 adds a fw_cfg node to the arm DSDT.

I made up some names - "FWCF" for the node name, and "FWCF0001"
for _HID; no idea whether that's appropriate, or how else I should
figure out what to use instead...

Also, using scope "\\_SB", based on where fw_cfg shows up in the
output of "info qtree". Again, if that's wrong, please point me in
the right direction.

Re. 3/3 (also mentioned after the commit blurb in the patch itself),
I noticed none of the other DSDT entries contain a _STA field, wondering
why it would (not) make sense to include that, same as on the PC.

TIA for any feedback, comments, reviews, etc.
 --Gabriel

Gabriel L. Somlo (3):
  pc: fw_cfg: move ioport base constant to pc.h
  acpi: pc: add fw_cfg device node to ssdt
  acpi: arm: add fw_cfg device node to dsdt

 hw/arm/virt-acpi-build.c | 18 ++++++++++++++++++
 hw/i386/acpi-build.c     | 19 +++++++++++++++++++
 hw/i386/pc.c             |  5 ++---
 include/hw/i386/pc.h     |  3 +++
 4 files changed, 42 insertions(+), 3 deletions(-)

-- 
2.4.3