Re: [Qemu-devel] [PATCH 20/34] linux-user: Remove redundant default action check in queue_signal()

[Peter Maydell]

On 6 September 2015 at 00:57, Timothy E Baldwin
<address@hidden> wrote:
> Both queue_signal() and process_pending_signals() did check for default
> actions of signals, this is redundant and also causes fatal and stopping
> signals to incorrectly cause guest system calls to be interrupted.
>
> The code in queue_signal() is removed.
>
> Signed-off-by: Timothy Edward Baldwin <address@hidden>

Is it really OK to always queue signals? This doesn't seem obviously
true to me, so some explanation of why it is would be helpful.

Also it looks like you've lost the handling of "we got a SIGSEGV
but the guest has blocked SIGSEGV".

thanks
-- PMM