Re: [Qemu-devel] [PATCH 2/9] sdl2: quick & dirty flicker workaround

[Marc-André Lureau]

On Wed, Sep 9, 2015 at 1:20 PM, Gerd Hoffmann <address@hidden> wrote:
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
>  ui/sdl2-2d.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
>

Reviewed-by: Marc-André Lureau <address@hidden>

> diff --git a/ui/sdl2-2d.c b/ui/sdl2-2d.c
> index d0b340f..191ee3b 100644
> --- a/ui/sdl2-2d.c
> +++ b/ui/sdl2-2d.c
> @@ -45,10 +45,23 @@ void sdl2_2d_update(DisplayChangeListener *dcl,
>          return;
>      }
>
> +    /*
> +     * SDL2 seems to do some double-buffering, and trying to only
> +     * update the changed areas results in only one of the two buffers
> +     * being updated.  Which flickers alot.  So lets not try to be
> +     * clever do a full update every time ...
> +     */
> +#if 0
>      rect.x = x;
>      rect.y = y;
>      rect.w = w;
>      rect.h = h;
> +#else
> +    rect.x = 0;
> +    rect.y = 0;
> +    rect.w = surface_width(surf);
> +    rect.h = surface_height(surf);
> +#endif
>
>      SDL_UpdateTexture(scon->texture, NULL, surface_data(surf),
>                        surface_stride(surf));
> --
> 1.8.3.1
>
>



-- 
Marc-André Lureau