qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/4] CODING_STYLE, checkpatch: update line lengt


From: Eduardo Habkost
Subject: Re: [Qemu-devel] [PATCH 2/4] CODING_STYLE, checkpatch: update line length rules
Date: Wed, 9 Sep 2015 16:23:29 -0300
User-agent: Mutt/1.5.23 (2014-03-12)

On Wed, Sep 09, 2015 at 06:22:15PM +0100, Peter Maydell wrote:
> On 7 September 2015 at 18:05, Markus Armbruster <address@hidden> wrote:
> > Paolo Bonzini <address@hidden> writes:
> >> That said, and even though Thomas obviously hasn't read the previous
> >> discussion, :) I do believe that 76 characters is too strict a limit.
> >
> > It's not a strict limit, it's a warning.  The strict limit is 90.
> 
> I tend to bounce patches on review for checkpatch warnings...
> I don't make much distinction between a warning and an error.

If there are existing warnings that will make you bounce patches
automatically, shouldn't they become errors?

I believe there are things we want to warn people about on checkpatch.pl
because they should be discouraged (like lines a bit longer than
76^H^H78^H^H79 columns), but that shouldn't make a patch be
automatically rejected.

-- 
Eduardo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]