Re: [Qemu-devel] [PATCH RFC v5 30/32] qapi: New QMP command query-qmp-schema for QMP introspection

[Markus Armbruster]

Eric Blake <address@hidden> writes:

> On 09/07/2015 04:16 AM, Markus Armbruster wrote:
>> qapi/introspect.json defines the introspection schema.  It's designed
>> for QMP introspection, but should do for similar uses, such as QGA.
>> 
>> The introspection schema does not reflect all the rules and
>> restrictions that apply to QAPI schemata.  A valid QAPI schema has an
>> introspection value conforming to the introspection schema, but the
>> converse is not true.
>> 
>
>>   Right now qmp_query_schema() sends the string literal computed by
>
> Should this be spelled qmp_query_qmp_schema()? [1]

Yes.

>>   qmp-introspect.py.  To compute sub-schema at run time, we'd have to
>>   duplicate parts of qapi-introspect.py in C.  Unattractive.
>
>
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>
> Changes I noticed from v4:
> Simple unions work now.
> Documentation improvements.
> Rename to query-qmp-schema (except perhaps where I marked [1], but I'm
> not too fussed with either spelling).
> Use of self._member for internal fields.
>
> Reviewed-by: Eric Blake <address@hidden>

Thanks!