[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC 0/5] disk deadlines
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH RFC 0/5] disk deadlines |
Date: |
Tue, 8 Sep 2015 11:43:53 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 |
On 08/09/2015 11:41, Denis V. Lunev wrote:
> This solution is far not perfect as there is a race window for
> request complete anyway. Though the amount of failures is
> reduced by 2-3 orders of magnitude.
>
> The behavior is similar not for soft mounts, which could
> corrupt the data but to hard mounts which are default AFAIR.
> It will not corrupt the data and should patiently wait
> request complete.
>
> Without the disk the guest is not able to serve any request and
> thus keeping it running does not make serious sense.
>
> This approach is used by Odin in production for years and
> we were able to seriously reduce the amount of end-user
> reclamations. We were unable to invent any reasonable
> solution without guest modification/timeouts tuning.
>
> Anyway, this code is off by default, storage agnostic, separated.
> Yes, we will be able to maintain it for us out-of-tree, but...
I'm not saying the patches are unacceptable, not at all. It just needs
a bit of documentation to understand the tradeoffs. I admit I have not
even started reading the code.
Your experience is very valuable, and it's great that you are
contributing it to QEMU and KVM!
Paolo
- Re: [Qemu-devel] [PATCH RFC 0/5] disk deadlines, (continued)
- Re: [Qemu-devel] [PATCH RFC 0/5] disk deadlines, Vasiliy Tolstov, 2015/09/08
- Re: [Qemu-devel] [PATCH RFC 0/5] disk deadlines, Fam Zheng, 2015/09/08
- Re: [Qemu-devel] [PATCH RFC 0/5] disk deadlines, Kevin Wolf, 2015/09/08
- Re: [Qemu-devel] [PATCH RFC 0/5] disk deadlines, Denis V. Lunev, 2015/09/08
- Re: [Qemu-devel] [PATCH RFC 0/5] disk deadlines, Fam Zheng, 2015/09/08
- Re: [Qemu-devel] [PATCH RFC 0/5] disk deadlines, Denis V. Lunev, 2015/09/08
- Re: [Qemu-devel] [PATCH RFC 0/5] disk deadlines, Kevin Wolf, 2015/09/08
- Re: [Qemu-devel] [PATCH RFC 0/5] disk deadlines, Fam Zheng, 2015/09/08
Re: [Qemu-devel] [PATCH RFC 0/5] disk deadlines, Paolo Bonzini, 2015/09/08
Re: [Qemu-devel] [PATCH RFC 0/5] disk deadlines, Kevin Wolf, 2015/09/08
Re: [Qemu-devel] [PATCH RFC 0/5] disk deadlines, Stefan Hajnoczi, 2015/09/08
Re: [Qemu-devel] [PATCH RFC 0/5] disk deadlines, John Snow, 2015/09/08
[Qemu-devel] Summary: [PATCH RFC 0/5] disk deadlines, Denis V. Lunev, 2015/09/10