[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [kvm-unit-tests PATCH 2/2] arm/arm64 config: Fix arch_c
From: |
Alexander Spyridakis |
Subject: |
Re: [Qemu-devel] [kvm-unit-tests PATCH 2/2] arm/arm64 config: Fix arch_clean rule |
Date: |
Mon, 7 Sep 2015 15:35:19 +0200 |
On 4 September 2015 at 16:05, Andrew Jones <address@hidden> wrote:
> This doesn't reproduce for me. I did the following, and it worked
> fine.
>
> make distclean
> ./configure --arch=arm --cross-prefix=arm-linux-gnu-
> make
> ./configure --arch=arm64 --cross-prefix=aarch64-linux-gnu-
> make clean && make
Ok I think I found the issue:
config-arm-common.mak:
>arm_clean: libfdt_clean asm_offsets_clean
> $(RM) $(TEST_DIR)/*.{o,flat,elf} $(libeabi) $(eabiobjs) \
> $(TEST_DIR)/.*.d lib/arm/.*.d
config-x86-common.mak:
>arch_clean:
> $(RM) $(TEST_DIR)/*.o $(TEST_DIR)/*.flat $(TEST_DIR)/*.elf \
> $(TEST_DIR)/.*.d lib/x86/.*.d
I think the arm case tries to be too clever and on many systems it
fails (tested on debian:jessie,sid and ubuntu:14.04,15.04). Basically
the expression for the arm case fails to resolve, while using the
simpler x86 way works as expected.
So is the following change acceptable in config-arm-common.mak?
> arm_clean: libfdt_clean asm_offsets_clean
>- $(RM) $(TEST_DIR)/*.{o,flat,elf} $(libeabi) $(eabiobjs) \
>- $(TEST_DIR)/.*.d lib/arm/.*.d
>+ $(RM) $(TEST_DIR)/*.o $(TEST_DIR)/*.flat $(TEST_DIR)/*.elf \
>+ $(libeabi) $(eabiobjs) $(TEST_DIR)/.*.d lib/arm/.*.d
Thanks.
- [Qemu-devel] [kvm-unit-tests PATCH 0/2] arm/arm64: Add self-modifying code test case, Alexander Spyridakis, 2015/09/02
- [Qemu-devel] [kvm-unit-tests PATCH 1/2] arm/arm64: Add self-modifying code test, Alexander Spyridakis, 2015/09/02
- [Qemu-devel] [kvm-unit-tests PATCH 2/2] arm/arm64 config: Fix arch_clean rule, Alexander Spyridakis, 2015/09/02
- Re: [Qemu-devel] [kvm-unit-tests PATCH 2/2] arm/arm64 config: Fix arch_clean rule, Andrew Jones, 2015/09/04
- Re: [Qemu-devel] [kvm-unit-tests PATCH 2/2] arm/arm64 config: Fix arch_clean rule, Alexander Spyridakis, 2015/09/04
- Re: [Qemu-devel] [kvm-unit-tests PATCH 2/2] arm/arm64 config: Fix arch_clean rule, Andrew Jones, 2015/09/04
- Re: [Qemu-devel] [kvm-unit-tests PATCH 2/2] arm/arm64 config: Fix arch_clean rule, Peter Maydell, 2015/09/04
- Re: [Qemu-devel] [kvm-unit-tests PATCH 2/2] arm/arm64 config: Fix arch_clean rule, Alexander Spyridakis, 2015/09/04
- Re: [Qemu-devel] [kvm-unit-tests PATCH 2/2] arm/arm64 config: Fix arch_clean rule,
Alexander Spyridakis <=
- Re: [Qemu-devel] [kvm-unit-tests PATCH 2/2] arm/arm64 config: Fix arch_clean rule, Andrew Jones, 2015/09/07
- Re: [Qemu-devel] [kvm-unit-tests PATCH 2/2] arm/arm64 config: Fix arch_clean rule, Alexander Spyridakis, 2015/09/07
- Re: [Qemu-devel] [kvm-unit-tests PATCH 2/2] arm/arm64 config: Fix arch_clean rule, Alexander Spyridakis, 2015/09/04
- Re: [Qemu-devel] [kvm-unit-tests PATCH 2/2] arm/arm64 config: Fix arch_clean rule, Andrew Jones, 2015/09/04