Re: [Qemu-devel] [PATCH 02/17] target-openrisc: Streamline arithmetic and OVE

[Bastian Koppelmann]

On 09/03/2015 04:44 PM, Richard Henderson wrote:
> That's patch 7/17.  ;-)

Woops , I just realized ;-)

> R0 is not an *architectural* zero.  It's a software convention.  The 
> spec is fairly clear on this point.
>
> I agree that there ought to be some special-casing of the software 
> convention, but that should require a TB flag to verify the convention 
> is followed.  But even then I would not bother retaining the special 
> case here in multiply.  I would only use it in the "move" and constant 
> formation types of pseudo instructions (or, ori, etc).

That sounds reasonable and is clearly for another patch, so

Reviewed-by: Bastian Koppelmann <address@hidden>

Cheers,
Bastian