Re: [Qemu-devel] [PATCH RFC v4 29/32] qapi: Pseudo-type '**' is now unused, drop it

[Eric Blake]

On 09/03/2015 08:30 AM, Markus Armbruster wrote:
> 'gen': false needs to stay for now, because netdev_add is still using
> it.
> 
> Signed-off-by: Markus Armbruster <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> ---

> +++ b/tests/Makefile
> @@ -228,7 +228,7 @@ check-qapi-schema-y := $(addprefix tests/qapi-schema/, \
>       bad-type-dict.json double-data.json unknown-expr-key.json \
>       redefined-type.json redefined-command.json redefined-builtin.json \
>       redefined-event.json command-int.json bad-data.json event-max.json \
> -     type-bypass.json type-bypass-no-gen.json type-bypass-bad-gen.json \
> +     type-bypass-bad-gen.json \
>       args-invalid.json \
>       args-array-empty.json args-array-unknown.json args-int.json \
>       args-unknown.json args-member-unknown.json args-member-array.json \

Not for this patch, but we aren't very consistent on any form of sorting
or line length in this section. It might be nicer if it were one test
per line (lots more line continuations) and/or alphabetical order.  If
that sounds nice, then it's a trivial patch to add in as one of the
followups after this series lands.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature