[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Patch for-2.5 v2 1/6] QAPI: move InetSocketAddress to
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [Patch for-2.5 v2 1/6] QAPI: move InetSocketAddress to qapi/common.json |
Date: |
Mon, 31 Aug 2015 11:04:26 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 |
On 08/11/2015 01:51 AM, Wen Congyang wrote:
> It will be used by BlockdevOptionsNBD.
>
> Signed-off-by: Wen Congyang <address@hidden>
> Signed-off-by: zhanghailiang <address@hidden>
> Signed-off-by: Gonglei <address@hidden>
> Reviewed-by: Alberto Garcia <address@hidden>
> ---
> qapi-schema.json | 27 ---------------------------
> qapi/common.json | 27 +++++++++++++++++++++++++++
> 2 files changed, 27 insertions(+), 27 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
> +++ b/qapi/common.json
> @@ -114,3 +114,30 @@
> ##
> { 'enum': 'OnOffAuto',
> 'data': [ 'auto', 'on', 'off' ] }
> +
> +##
> +# @InetSocketAddress
> +#
> +# Captures a socket address or address range in the Internet namespace.
> +#
> +# @host: host part of the address
> +#
> +# @port: port part of the address, or lowest port if @to is present
> +#
> +# @to: highest port to try
> +#
> +# @ipv4: whether to accept IPv4 addresses, default try both IPv4 and IPv6
> +# #optional
> +#
> +# @ipv6: whether to accept IPv6 addresses, default try both IPv4 and IPv6
> +# #optional
> +#
> +# Since 1.3
> +##
> +{ 'struct': 'InetSocketAddress',
> + 'data': {
> + 'host': 'str',
> + 'port': 'str',
> + '*to': 'uint16',
The fact that 'port' is sometimes textual, and sometimes an integer, is
pre-existing, so moving it does not affect the validity of this patch.
But I wonder if we should in the future add an 'alternate' type that
allows us to directly pass an integer for 'port', rather than always
having to pass a stringized integer.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [Patch for-2.5 v2 0/6] qapi: child add/delete support, Wen Congyang, 2015/08/11
- [Qemu-devel] [Patch for-2.5 v2 1/6] QAPI: move InetSocketAddress to qapi/common.json, Wen Congyang, 2015/08/11
- Re: [Qemu-devel] [Patch for-2.5 v2 1/6] QAPI: move InetSocketAddress to qapi/common.json,
Eric Blake <=
- [Qemu-devel] [Patch for-2.5 v2 3/6] Add new block driver interface to add/delete a BDS's child, Wen Congyang, 2015/08/11
- [Qemu-devel] [Patch for-2.5 v2 2/6] support nbd driver in blockdev-add, Wen Congyang, 2015/08/11
- [Qemu-devel] [Patch for-2.5 v2 6/6] hmp: add monitor command to add/remove a child, Wen Congyang, 2015/08/11
- [Qemu-devel] [Patch for-2.5 v2 5/6] qmp: add monitor command to add/remove a child, Wen Congyang, 2015/08/11