Re: [Qemu-devel] [PATCH COLO-Frame v8 06/34] migration: Integrate COLO checkpoint process into migration

[zhanghailiang]

On 2015/8/29 5:55, Eric Blake wrote:
> On 07/29/2015 02:45 AM, zhanghailiang wrote:
> > Add a migrate state: MIGRATION_STATUS_COLO, enter this migration state
> > after the first live migration successfully finished.
> >
> > Signed-off-by: zhanghailiang <address@hidden>
> > Signed-off-by: Li Zhijian <address@hidden>
> > Signed-off-by: Gonglei <address@hidden>
> > ---
> >   include/migration/colo.h |  3 +++
> >   migration/colo.c         | 58 ++++++++++++++++++++++++++++++++++++++++++++++++
> >   migration/migration.c    | 23 ++++++++++++++-----
> >   qapi-schema.json         |  2 +-
> >   stubs/migration-colo.c   |  9 ++++++++
> >   trace-events             |  3 +++
> >   6 files changed, 92 insertions(+), 6 deletions(-)
>
> Just an interface review.
>
> > +++ b/qapi-schema.json
> > @@ -433,7 +433,7 @@
> >   ##
> >   { 'enum': 'MigrationStatus',
> >     'data': [ 'none', 'setup', 'cancelling', 'cancelled',
> > -            'active', 'completed', 'failed' ] }
> > +            'active', 'completed', 'failed', 'colo' ] }
>
> Missing documentation.

Will add in next version, thanks.