[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 6/9] tcg: synchronize cpu->exit_request and cpu-
From: |
Emilio G. Cota |
Subject: |
Re: [Qemu-devel] [PATCH 6/9] tcg: synchronize cpu->exit_request and cpu->tcg_exit_req accesses |
Date: |
Thu, 27 Aug 2015 22:19:54 -0400 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Aug 26, 2015 at 02:17:42 +0200, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> cpu-exec.c | 6 +++++-
> qom/cpu.c | 2 ++
> 2 files changed, 7 insertions(+), 1 deletion(-)
I like this patch.
Are we making sure that other writes to tcg_exit_req are preceded by
a write barrier? For instance:
qom/cpu.c-116- cpu->exit_request = 1;
qom/cpu.c:117: cpu->tcg_exit_req = 1;
translate-all.c-1478- } else {
translate-all.c:1479: cpu->tcg_exit_req = 1;
translate-all.c-1643- cpu->interrupt_request |= mask;
translate-all.c:1644: cpu->tcg_exit_req = 1;
Current master certainly doesn't have them, but I wonder if
you have barriers at those places in the tree you're working on. If not
I'd expand this patch to add them.
And while at it, can we pleeease get rid of the hideous 'volatile sigatomic_t'
type for tcg_exit_req?
Thanks,
Emilio
- [Qemu-devel] [PATCH v2 0/9] tcg: signal-free qemu_cpu_kick, Paolo Bonzini, 2015/08/25
- [Qemu-devel] [PATCH 3/9] tcg: introduce tcg_current_cpu, Paolo Bonzini, 2015/08/25
- [Qemu-devel] [PATCH 1/9] i8257: rewrite DMA_schedule to avoid hooking into the CPU loop, Paolo Bonzini, 2015/08/25
- [Qemu-devel] [PATCH 5/9] tcg: assign cpu->current_tb in a simpler place, Paolo Bonzini, 2015/08/25
- [Qemu-devel] [PATCH 2/9] i8257: remove cpu_request_exit irq, Paolo Bonzini, 2015/08/25
- [Qemu-devel] [PATCH 6/9] tcg: synchronize cpu->exit_request and cpu->tcg_exit_req accesses, Paolo Bonzini, 2015/08/25
- Re: [Qemu-devel] [PATCH 6/9] tcg: synchronize cpu->exit_request and cpu->tcg_exit_req accesses,
Emilio G. Cota <=
- [Qemu-devel] [PATCH 4/9] remove qemu/tls.h, Paolo Bonzini, 2015/08/25
- [Qemu-devel] [PATCH 7/9] tcg: synchronize exit_request and tcg_current_cpu accesses, Paolo Bonzini, 2015/08/25
- [Qemu-devel] [PATCH 8/9] use qemu_cpu_kick instead of cpu_exit or qemu_cpu_kick_thread, Paolo Bonzini, 2015/08/25
- [Qemu-devel] [PATCH 9/9] tcg: signal-free qemu_cpu_kick, Paolo Bonzini, 2015/08/25
- Re: [Qemu-devel] [PATCH v2 0/9] tcg: signal-free qemu_cpu_kick, Richard Henderson, 2015/08/28