[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] memory: allow zero size for adjust_endianne
From: |
Jason Wang |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] memory: allow zero size for adjust_endianness() |
Date: |
Thu, 27 Aug 2015 12:50:19 +0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 |
On 08/26/2015 10:51 PM, Greg Kurz wrote:
> On Wed, 26 Aug 2015 15:21:59 +0100
> Peter Maydell <address@hidden> wrote:
>
>> On 26 August 2015 at 11:04, Jason Wang <address@hidden> wrote:
>>> Wildcard mmio eventfd use zero size, but it will lead abort() since it
>>> was illegal in adjust_endianness(). Fix this by allowing zero size.
>>>
>>> Cc: Greg Kurz <address@hidden>
>>> Cc: Paolo Bonzini <address@hidden>
>>> Signed-off-by: Jason Wang <address@hidden>
>> This seems to me like a bug in the caller. Why would anything
>> try to call into the memory subsystem to do a zero-size
>> transaction?
>>
>> thanks
>> -- PMM
>>
> Here's the patch which needs zero-size eventfd:
>
> http://patchwork.ozlabs.org/patch/509428/
>
> Cheers.
>
> --
> Greg
>
Yes, this is because we want to use wildcard mmio eventfd (which
requires size to be zero) to speed up virtio 1.0 mmio.
- [Qemu-devel] [PATCH 1/2] memory: allow zero size for adjust_endianness(), Jason Wang, 2015/08/26
- [Qemu-devel] [PATCH 2/2] pci: test-dev: try to test fast mmio bus for wildcard mmio event, Jason Wang, 2015/08/26
- Re: [Qemu-devel] [PATCH 1/2] memory: allow zero size for adjust_endianness(), Peter Maydell, 2015/08/26
- Re: [Qemu-devel] [PATCH 1/2] memory: allow zero size for adjust_endianness(), Greg Kurz, 2015/08/26
- Re: [Qemu-devel] [PATCH 1/2] memory: allow zero size for adjust_endianness(),
Jason Wang <=
- Re: [Qemu-devel] [PATCH 1/2] memory: allow zero size for adjust_endianness(), Peter Maydell, 2015/08/27
- Re: [Qemu-devel] [PATCH 1/2] memory: allow zero size for adjust_endianness(), Michael S. Tsirkin, 2015/08/27
- Re: [Qemu-devel] [PATCH 1/2] memory: allow zero size for adjust_endianness(), Peter Maydell, 2015/08/27
- Re: [Qemu-devel] [PATCH 1/2] memory: allow zero size for adjust_endianness(), Michael S. Tsirkin, 2015/08/27
- Re: [Qemu-devel] [PATCH 1/2] memory: allow zero size for adjust_endianness(), Peter Maydell, 2015/08/27
- Re: [Qemu-devel] [PATCH 1/2] memory: allow zero size for adjust_endianness(), Michael S. Tsirkin, 2015/08/27
- Re: [Qemu-devel] [PATCH 1/2] memory: allow zero size for adjust_endianness(), Peter Maydell, 2015/08/27
- Re: [Qemu-devel] [PATCH 1/2] memory: allow zero size for adjust_endianness(), Michael S. Tsirkin, 2015/08/27
- Re: [Qemu-devel] [PATCH 1/2] memory: allow zero size for adjust_endianness(), Peter Maydell, 2015/08/27
- Re: [Qemu-devel] [PATCH 1/2] memory: allow zero size for adjust_endianness(), Michael S. Tsirkin, 2015/08/27