[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] net/vmxnet3: Flush packets when device gets act
|
From: |
Fam Zheng |
|
Subject: |
Re: [Qemu-devel] [PATCH] net/vmxnet3: Flush packets when device gets activated |
|
Date: |
Thu, 20 Aug 2015 02:45:47 +0800 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Tue, 08/18 14:25, Shmulik Ladkani wrote:
> As of a90a7425cf592a3afeff3eaf32f543b83050ee5c 'tap: Drop tap_can_send'
> vmxnet3 (with tap networking) can no longer receive once device is
> deactivated.
> Alas, as the device is initially "inactive", this brakes vmxnet3
> receive functionality.
>
> vmxnet3_can_receive() checks its internal 'device_active' flag (among
> other tests).
> However, as of a90a7425cf, if 'device_active' is false, packets will be
> queued by tap_send (at qemu_net_queue_send).
>
> However, vmxnet3 never flushes the queue, even if the device is later
> activated.
>
> Fix by calling 'qemu_flush_queued_packets()' when vmxnet3 device gets
> active.
>
> Signed-off-by: Shmulik Ladkani <address@hidden>
Looks like the previous patch to fix this fell between the cracks and never
made it to qemu.git?
http://patchwork.ozlabs.org/patch/489847/
Stefan, any idea?
Fam