[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC 02/11] ide: necessary fields for ATAPI-SCSI
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH RFC 02/11] ide: necessary fields for ATAPI-SCSI bridge added |
Date: |
Tue, 18 Aug 2015 16:50:00 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 |
On 17/08/15 16:42, Alexander Bezzubikov wrote:
> Signed-off-by: Alexander Bezzubikov <address@hidden>
> ---
> hw/ide/internal.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/hw/ide/internal.h b/hw/ide/internal.h
> index f2999ce..3ebc63c 100644
> --- a/hw/ide/internal.h
> +++ b/hw/ide/internal.h
> @@ -429,6 +429,8 @@ struct IDEState {
> uint8_t *smart_selftest_data;
> /* AHCI */
> int ncq_queues;
> + /* ATAPI-SCSI bridge */
> + SCSIRequest *cur_req;
Considering that you're extending struct *IDEState* here, I think the
name "cur_req" might be a little bit misleading? Maybe rather name it
"scsi_req" or "atapi_req"?
Thomas
- Re: [Qemu-devel] [PATCH RFC 08/11] scsi: SCSIDiskReq declaration moved to header, (continued)
- [Qemu-devel] [PATCH RFC 01/11] ide: ATAPI-SCSI bridge TypeInfo and init function created, Alexander Bezzubikov, 2015/08/17
- [Qemu-devel] [PATCH RFC 10/11] ide: corrected ATAPI checks to be ignored by ATAPI-SCSI bridge, Alexander Bezzubikov, 2015/08/17
- [Qemu-devel] [PATCH RFC 11/11] ide: bridge functions assigned to SCSIBusInfo, bridge is OK now, Alexander Bezzubikov, 2015/08/18
- Re: [Qemu-devel] [PATCH RFC 00/11] QEMU ATAPI-SCSI bridge GSoC project, Hannes Reinecke, 2015/08/18
- [Qemu-devel] [PATCH RFC 02/11] ide: necessary fields for ATAPI-SCSI bridge added, Alexander Bezzubikov, 2015/08/18
- [Qemu-devel] [PATCH RFC 04/11] scsi: Added function to enable ATAPI-SCSI bridge send SCSI requests, Alexander Bezzubikov, 2015/08/18
- [Qemu-devel] [PATCH RFC 03/11] ide: necessary checks corrected to treat ATAPI-SCSI bridge as CDROM, Alexander Bezzubikov, 2015/08/18
- [Qemu-devel] [PATCH RFC 09/11] ide: ide_bridge_do_transfer is treated as PIO transfer, Alexander Bezzubikov, 2015/08/18