[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v10 3/5] arm_kvm: Do not assume particular GIC t
From: |
Eric Auger |
Subject: |
Re: [Qemu-devel] [PATCH v10 3/5] arm_kvm: Do not assume particular GIC type in kvm_arch_irqchip_create() |
Date: |
Tue, 18 Aug 2015 17:57:28 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 |
Reviewed-by: Eric Auger <address@hidden>
On 08/18/2015 03:33 PM, Pavel Fedin wrote:
> This allows to use different GIC types from v2. There are no kernels which
> could advertise KVM_CAP_DEVICE_CTRL without the actual ability to create
> GIC with it.
>
> Signed-off-by: Pavel Fedin <address@hidden>
> ---
> target-arm/kvm.c | 10 +---------
> 1 file changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/target-arm/kvm.c b/target-arm/kvm.c
> index b278542..22383c5 100644
> --- a/target-arm/kvm.c
> +++ b/target-arm/kvm.c
> @@ -585,18 +585,10 @@ void kvm_arch_init_irq_routing(KVMState *s)
>
> int kvm_arch_irqchip_create(KVMState *s)
> {
> - int ret;
> -
> /* If we can create the VGIC using the newer device control API, we
> * let the device do this when it initializes itself, otherwise we
> * fall back to the old API */
> -
> - ret = kvm_create_device(s, KVM_DEV_TYPE_ARM_VGIC_V2, true);
> - if (ret == 0) {
> - return 1;
> - }
> -
> - return 0;
> + return kvm_check_extension(s, KVM_CAP_DEVICE_CTRL);
> }
>
> int kvm_arch_fixup_msi_route(struct kvm_irq_routing_entry *route,
>