[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 08/10] xen/pt: Make xen_pt_unregister_device
From: |
Konrad Rzeszutek Wilk |
Subject: |
Re: [Qemu-devel] [PATCH v1 08/10] xen/pt: Make xen_pt_unregister_device idempotent |
Date: |
Fri, 14 Aug 2015 16:20:43 -0400 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
> > @@ -818,10 +819,13 @@ static void xen_pt_unregister_device(PCIDevice *d)
> > {
> > XenPCIPassthroughState *s = XEN_PT_DEVICE(d);
> > uint8_t machine_irq = s->machine_irq;
> > - uint8_t intx = xen_pt_pci_intx(s);
> > + uint8_t intx;
> > int rc;
> >
> > - if (machine_irq) {
> > + /* Note that if xen_host_pci_device_put had closed config_fd, then
> > + * intx value becomes 0xff. */
> > + intx = xen_pt_pci_intx(s);
>
> Wouldn't it make sense to move this assignment inside the if below?
Totally. Plus it also allows me to remove the comment above.
>
> Aside from this small item:
>
> Reviewed-by: Stefano Stabellini <address@hidden>
Thank you.
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v1 08/10] xen/pt: Make xen_pt_unregister_device idempotent,
Konrad Rzeszutek Wilk <=