Re: [Qemu-devel] [PATCH for-2.5 22/30] m68k: add cas instruction

[Richard Henderson]

On 08/09/2015 01:13 PM, Laurent Vivier wrote:
> +    gen_logic_cc(s, res, opsize);
> +
> +    l1 = gen_new_label();
> +    l2 = gen_new_label();
> +
> +    gen_jmpcc(s, 6 /* !Z */, l1);
> +    gen_store(s, opsize, addr, update);
> +    tcg_gen_br(l2);
> +    gen_set_label(l1);
> +    tcg_gen_mov_i32(cmp, dest);
> +    gen_set_label(l2);
> +    tcg_temp_free(dest);
> +    tcg_temp_free(addr);

I would suggest writing this with movcond.  It avoids the branch, which is
requiring the use of the local temps.



r~