[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC PATCH V7 18/19] mttcg: signal the associated cpu anywa
From: |
fred . konrad |
Subject: |
[Qemu-devel] [RFC PATCH V7 18/19] mttcg: signal the associated cpu anyway. |
Date: |
Mon, 10 Aug 2015 17:27:16 +0200 |
From: KONRAD Frederic <address@hidden>
We might have a race here. If current_cpu is about to be set then cpu_exit won't
be called and we don't exit TCG. This was probably an issue with old
implementation as well.
Signed-off-by: KONRAD Frederic <address@hidden>
---
cpus.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/cpus.c b/cpus.c
index 2c5ca72..f61530c 100644
--- a/cpus.c
+++ b/cpus.c
@@ -674,8 +674,7 @@ static void cpu_signal(int sig)
cpu_exit(current_cpu);
}
- /* FIXME: We might want to check if the cpu is running? */
- tcg_thread_cpu->exit_request = true;
+ cpu_exit(tcg_thread_cpu);
}
#ifdef CONFIG_LINUX
--
1.9.0
- [Qemu-devel] [RFC PATCH V7 13/19] add a callback when tb_invalidate is called., (continued)
- [Qemu-devel] [RFC PATCH V7 13/19] add a callback when tb_invalidate is called., fred . konrad, 2015/08/10
- [Qemu-devel] [RFC PATCH V7 10/19] cpu: remove exit_request global., fred . konrad, 2015/08/10
- [Qemu-devel] [RFC PATCH V7 12/19] Use atomic cmpxchg to atomically check the exclusive value in a STREX, fred . konrad, 2015/08/10
- [Qemu-devel] [RFC PATCH V7 14/19] cpu: introduce tlb_flush*_all., fred . konrad, 2015/08/10
- [Qemu-devel] [RFC PATCH V7 15/19] arm: use tlb_flush*_all, fred . konrad, 2015/08/10
- [Qemu-devel] [RFC PATCH V7 18/19] mttcg: signal the associated cpu anyway.,
fred . konrad <=
- [Qemu-devel] [RFC PATCH V7 16/19] translate-all: introduces tb_flush_safe., fred . konrad, 2015/08/10
- [Qemu-devel] [RFC PATCH V7 17/19] translate-all: (wip) use tb_flush_safe when we can't alloc more tb., fred . konrad, 2015/08/10
- [Qemu-devel] [RFC PATCH V7 19/19] target-arm/psci.c: wake up sleeping CPUs (MTTCG), fred . konrad, 2015/08/10