Re: [Qemu-devel] [PATCH v2 4/5] vhost-user: Enable 'nowait' and 'reconnect' option

[Marc-André Lureau]

Hi

On Mon, Jun 22, 2015 at 5:50 AM, Tetsuya Mukawa <address@hidden> wrote:
> The patch enables 'nowait' option for server mode, and 'reconnect'
> option for client mode.
>
> Signed-off-by: Tetsuya Mukawa <address@hidden>
> ---
>  net/vhost-user.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/net/vhost-user.c b/net/vhost-user.c
> index 8b7749a..58cd5dc 100644
> --- a/net/vhost-user.c
> +++ b/net/vhost-user.c
> @@ -26,6 +26,8 @@ typedef struct VhostUserChardevProps {
>      bool is_socket;
>      bool is_unix;
>      bool is_server;
> +    bool is_nowait;
> +    bool is_reconnect;
>  } VhostUserChardevProps;
>
>  VHostNetState *vhost_user_get_vhost_net(NetClientState *nc)
> @@ -186,6 +188,10 @@ static int net_vhost_chardev_opts(void *opaque,
>          props->is_unix = true;
>      } else if (strcmp(name, "server") == 0) {
>          props->is_server = true;
> +    } else if ((strcmp(name, "wait") == 0) && (strcmp(value, "off")) == 0) {
> +        props->is_nowait = true;
> +    } else if (strcmp(name, "reconnect") == 0) {
> +        props->is_reconnect = true;
>      } else {
>          error_setg(errp,
>                     "vhost-user does not support a chardev with option %s=%s",

I don't see the point in saving all those options... is_server could
be removed too, in a separate patch


-- 
Marc-André Lureau