[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 07/26] qapi: Fix generated code when flat union
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 07/26] qapi: Fix generated code when flat union has member 'kind' |
Date: |
Wed, 05 Aug 2015 07:24:54 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Eric Blake <address@hidden> writes:
> On 08/04/2015 03:17 AM, Markus Armbruster wrote:
>> A flat union's tag member gets renamed to 'kind' in the generated
>> code. Breaks when another member is named 'kind' exists.
>
> Too many verbs. Drop either 'is' or 'exists'.
Will fix.
>>
>> Example, adapted from qapi-schema-test.json:
>>
>> { 'struct': 'UserDefUnionBase',
>> 'data': { 'kind': 'str', 'enum1': 'EnumOne' } }
>>
>> We generate:
>>
>> struct UserDefFlatUnion
>> {
>> EnumOne kind;
>> union {
>> void *data;
>> UserDefA *value1;
>> UserDefB *value2;
>> UserDefB *value3;
>> };
>> char *kind;
>> };
>>
>> Kill the silly rename.
>>
>> Reported-by: Eric Blake <address@hidden>
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>> scripts/qapi-types.py | 3 ++-
>> scripts/qapi-visit.py | 7 +++++--
>> tests/test-qmp-input-visitor.c | 2 +-
>> tests/test-qmp-output-visitor.c | 2 +-
>> 4 files changed, 9 insertions(+), 5 deletions(-)
>
> Reviewed-by: Eric Blake <address@hidden>
Thanks!
- [Qemu-devel] [PATCH 05/26] qapi: Reject -p arguments that break qapi-event.py, (continued)
- [Qemu-devel] [PATCH 05/26] qapi: Reject -p arguments that break qapi-event.py, Markus Armbruster, 2015/08/04
- [Qemu-devel] [PATCH 08/26] qapi: Generate a nicer struct for flat unions, Markus Armbruster, 2015/08/04
- [Qemu-devel] [PATCH 10/26] qapi-visit: Replace list implicit_structs by set, Markus Armbruster, 2015/08/04
- [Qemu-devel] [PATCH 15/26] qapi: Document shortcoming with union 'data' branch, Markus Armbruster, 2015/08/04
- [Qemu-devel] [PATCH 02/26] qapi: Clean up cgen() and mcgen(), Markus Armbruster, 2015/08/04
- [Qemu-devel] [PATCH 07/26] qapi: Fix generated code when flat union has member 'kind', Markus Armbruster, 2015/08/04
- [Qemu-devel] [PATCH 20/26] qapi: Fix to reject union command and event arguments, Markus Armbruster, 2015/08/04
- [Qemu-devel] [PATCH 25/26] qapi-commands: Drop useless initialization, Markus Armbruster, 2015/08/04
- [Qemu-devel] [PATCH 16/26] qapi: Document flaws in checking of names, Markus Armbruster, 2015/08/04
- [Qemu-devel] [PATCH 17/26] tests/qapi-schema: Restore test case for flat union base bug, Markus Armbruster, 2015/08/04
- [Qemu-devel] [PATCH 14/26] qapi: Document that input visitor semantics are prone to leaks, Markus Armbruster, 2015/08/04