[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC v3 06/32] qapi: Split up some typedefs to ea
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH RFC v3 06/32] qapi: Split up some typedefs to ease review |
Date: |
Tue, 4 Aug 2015 16:37:06 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 |
On 08/04/2015 09:57 AM, Markus Armbruster wrote:
> One of the next patches will among other things generate a separate
> typedef for some struct types, i.e.
>
> typedef struct FOO FOO;
>
> struct FOO {
> ...
> };
>
> instead of
>
> typedef struct FOO {
> ...
> } FOO;
>
> To make the generated files easier to diff, anticipate the change.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> scripts/qapi-types.py | 18 ++++++++++++------
> 1 file changed, 12 insertions(+), 6 deletions(-)
No R-b, since you revert it and intend to omit it on v4; but thanks for
doing this! It helped.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH RFC v3 00/32] qapi: QMP introspection, Markus Armbruster, 2015/08/04
- [Qemu-devel] [PATCH RFC v3 09/32] Revert "qapi: Split up some typedefs to ease review", Markus Armbruster, 2015/08/04
- [Qemu-devel] [PATCH RFC v3 01/32] qapi: Rename class QAPISchema to QAPISchemaParser, Markus Armbruster, 2015/08/04
- [Qemu-devel] [PATCH RFC v3 14/32] qapi-event: Eliminate global variable event_enum_value, Markus Armbruster, 2015/08/04
- [Qemu-devel] [PATCH RFC v3 04/32] qapi: New QAPISchemaVisitor, Markus Armbruster, 2015/08/04
- [Qemu-devel] [PATCH RFC v3 06/32] qapi: Split up some typedefs to ease review, Markus Armbruster, 2015/08/04
- Re: [Qemu-devel] [PATCH RFC v3 06/32] qapi: Split up some typedefs to ease review,
Eric Blake <=
- [Qemu-devel] [PATCH RFC v3 03/32] qapi: QAPISchema code generation helper methods, Markus Armbruster, 2015/08/04
- [Qemu-devel] [PATCH RFC v3 02/32] qapi: New QAPISchema intermediate reperesentation, Markus Armbruster, 2015/08/04
[Qemu-devel] [PATCH RFC v3 08/32] Revert "qapi: Generate comments to simplify splitting for review", Markus Armbruster, 2015/08/04
[Qemu-devel] [PATCH RFC v3 12/32] qapi-commands: Convert to QAPISchemaVisitor, Markus Armbruster, 2015/08/04