[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/3] target-mips: Copy restrictions from ext/
From: |
Leon Alrae |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/3] target-mips: Copy restrictions from ext/ins to dext/dins |
Date: |
Tue, 4 Aug 2015 11:49:42 +0100 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
On 03/08/2015 20:35, Richard Henderson wrote:
> The checks in dins is required to avoid triggering an assertion
> in tcg_gen_deposit_tl. The check in dext is just for completeness.
> Fold the other D cases in via fallthru.
>
> In this case the errant dins appears to be data, not code, as
> translation failed to stop after a break insn.
>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
> target-mips/translate.c | 45 +++++++++++++++++++++++++--------------------
> 1 file changed, 25 insertions(+), 20 deletions(-)
Reviewed-by: Leon Alrae <address@hidden>
I'll send out the pull request including this single patch from the series as
well as semihosting microMIPS R6 fix soon (just waiting for tests to finish...).
Thanks,
Leon
- [Qemu-devel] [PATCH 2/3] target-mips: Stop translation after unconditional exceptions, (continued)
- Re: [Qemu-devel] [PATCH v2 1/3] target-mips: Copy restrictions from ext/ins to dext/dins,
Leon Alrae <=
[Qemu-devel] [PATCH 3/3] target-mips: Use CPU_LOG_INT for logging related to interrupts, Richard Henderson, 2015/08/03