Re: [Qemu-devel] [PATCH] bsd-user: Fix operand to cpu_x86_exec

[Peter Maydell]

On 29 July 2015 at 22:22, Peter Maydell <address@hidden> wrote:
> On 29 July 2015 at 19:40, Richard Henderson <address@hidden> wrote:
>> Signed-off-by: Richard Henderson <address@hidden>
>> ---
>> This buglet, from whenever we re-orged the parameters, means
>> that all x86-bsd-user invocations die instantly.
>>
>>
>> r~
>> ---
>>  bsd-user/main.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/bsd-user/main.c b/bsd-user/main.c
>> index f46728b..ee68daa 100644
>> --- a/bsd-user/main.c
>> +++ b/bsd-user/main.c
>> @@ -173,7 +173,7 @@ void cpu_loop(CPUX86State *env)
>>      //target_siginfo_t info;
>>
>>      for(;;) {
>> -        trapnr = cpu_x86_exec(env);
>> +        trapnr = cpu_x86_exec(cs);
>>          switch(trapnr) {
>>          case 0x80:
>>              /* syscall from int $0x80 */
>
> Whoops. This sounds like it's worth putting into 2.4...
>
> Reviewed-by: Peter Maydell <address@hidden>

Applied, thanks.

-- PMM