qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH for-2.5 03/10] tcg/optimize: track const/copy st


From: Aurelien Jarno
Subject: Re: [Qemu-devel] [PATCH for-2.5 03/10] tcg/optimize: track const/copy status separately
Date: Wed, 29 Jul 2015 18:25:21 +0200
User-agent: Mutt/1.5.23 (2014-03-12)

On 2015-07-29 17:10, Alex Bennée wrote:
> 
> Aurelien Jarno <address@hidden> writes:
> 
> > Use two bools to track constants and copies instead of an enum.
> 
> More of an explanation would be useful as to why, otherwise it seems to
> me we are just increasing the size of the structure (assuming the
> compiler uses the same base sizes for the bool and enum).

The reason is in the following patch, to allow separate tracking of const
and copy. Note that this doesn't increase the structure size due to
alignment and that the v2 of this patchset actually uses only one bool.

I'll add a note about why it is need for v3.


-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
address@hidden                 http://www.aurel32.net



reply via email to

[Prev in Thread] Current Thread [Next in Thread]