[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3] hw/arm/virt: Add high MMIO PCI region
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [PATCH v3] hw/arm/virt: Add high MMIO PCI region |
Date: |
Wed, 29 Jul 2015 11:10:55 +0200 |
On Mon, 27 Jul 2015 14:09:28 +0300
Pavel Fedin <address@hidden> wrote:
> @@ -234,6 +236,12 @@ static void acpi_dsdt_add_pci(Aml *scope, const
> MemMapEntry *memmap, int irq)
> AML_ENTIRE_RANGE, 0x0000, 0x0000, size_pio - 1,
> base_pio,
> size_pio));
>
> + aml_append(rbuf,
> + aml_dword_memory(AML_POS_DECODE, AML_MIN_FIXED, AML_MAX_FIXED,
this is wrong since dword is too small for values of high memory
use aml_qword_memory() instead
> + AML_NON_CACHEABLE, AML_READ_WRITE, 0x0000,
> + base_mmio_high, base_mmio_high + size_mmio_high - 1,
since window is at fixed position and it's not possible for guest to
move base address of the range, make AddressMaximum the same as AddressMinimum
i.e.
s/base_mmio_high + size_mmio_high - 1/base_mmio_high/
> + 0x0000, size_mmio_high));
- Re: [Qemu-devel] [PATCH v3] hw/arm/virt: Add high MMIO PCI region, (continued)
- Re: [Qemu-devel] [PATCH v3] hw/arm/virt: Add high MMIO PCI region, Igor Mammedov, 2015/07/29
- Re: [Qemu-devel] [PATCH v3] hw/arm/virt: Add high MMIO PCI region, Pavel Fedin, 2015/07/29
- Re: [Qemu-devel] [PATCH v3] hw/arm/virt: Add high MMIO PCI region, Peter Maydell, 2015/07/29
- Re: [Qemu-devel] [PATCH v3] hw/arm/virt: Add high MMIO PCI region, Igor Mammedov, 2015/07/29
- Re: [Qemu-devel] [PATCH v3] hw/arm/virt: Add high MMIO PCI region, Pavel Fedin, 2015/07/29
- Re: [Qemu-devel] [PATCH v3] hw/arm/virt: Add high MMIO PCI region, Peter Maydell, 2015/07/29
Re: [Qemu-devel] [PATCH v3] hw/arm/virt: Add high MMIO PCI region,
Igor Mammedov <=