[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/2] AioContext: fix deadlock after aio_conte
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 0/2] AioContext: fix deadlock after aio_context_acquire() race |
|
Date: |
Tue, 28 Jul 2015 18:17:27 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 |
On 28/07/2015 16:08, Stefan Hajnoczi wrote:
>> > v2:
>> > * Free BHs after thread_pool_free(), which calls qemu_bh_delete()
>> > [Cornelia]
>> > * Remove assert for leaked BHs since we don't know how many existing cases
>> > there are yet and QEMU 2.4-rc3 is a poor time to risk assertion failures
> The v2 isn't necessary if we apply Paolo's "[PATCH for-2.4] block:
> delete bottom halves before the AioContext is freed" on top of my v1.
> Paolo has audited all BHs so the risk of hitting assertion failures is
> very low.
As you prefer; you're right that there is no use-after-free because of
the way you wrote patch 1/2.
Paolo