qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] raw-posix.c: Make GetBSDPath() handle caching o


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH] raw-posix.c: Make GetBSDPath() handle caching options
Date: Tue, 28 Jul 2015 11:18:32 +0100
User-agent: Mutt/1.5.23 (2014-03-12)

On Mon, Jul 27, 2015 at 12:28:03PM -0400, Programmingkid wrote:
> Add support for caching options that can be specified from
> the command line. 

Please squash this into the commit message when merging:

The CD-ROM raw char device bypasses the host page cache and therefore
has alignment requirements.  Alignment probing is necessary so only use
the raw char device if BDRV_O_NOCACHE is set.

This patch fixes -cdrom /dev/cdrom on Mac OS X hosts, where bdrv_read()
used to fail due to misaligned requests during image format probing.

Reviewed-by: Stefan Hajnoczi <address@hidden>

Attachment: pgp0VnCNqf9h8.pgp
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]