[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v7 00/42] Postcopy implementation

From: Amit Shah
Subject: Re: [Qemu-devel] [PATCH v7 00/42] Postcopy implementation
Date: Tue, 28 Jul 2015 11:51:54 +0530

On (Tue) 16 Jun 2015 [11:26:13], Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <address@hidden>
>   This is the 7th cut of my version of postcopy; it is designed for use with
> the Linux kernel additions posted by Andrea Arcangeli here:
> git clone --reference linux -b userfault21
> git://git.kernel.org/pub/scm/linux/kernel/git/andrea/aa.git
> Note this API is slightly different from the last version; but the code is now
> in the linux-mm tree, the API is getting stable and the kernel code is just
> getting fixes now.
> This qemu series can be found at:
> https://github.com/orbitfp7/qemu.git
> on the wp3-postcopy-v7 tag.
> It addresses most of the previous review comments, but there are
> still one or two I'm working.
> As with v6, the userfaultfd.h isn't included in the tree, so you'll
> need a userfaultfd.h header (and syscall define) from Andrea's kernel.
> This work has been partially funded by the EU Orbit project:
>   see http://www.orbitproject.eu/about/

Very well-split series, that must've taken a lot of work, but makes
reviewing much easier, thanks a lot for that.

I'm mostly through the whole set, a few patches remain.  I don't think
there's anything major here.

As I've said previously, I'll prefer to merge when the kernel patches
are in.  However, we can go ahead with the x- prefix, so we don't
declare anything as a supported interface yet.  Also, configure
disabling this by default because we won't have the syscall number.
If you agree, we can include this early in the 2.5 series.

In addition to the few comments on individual patches, there's
something I noted in multiple patches:

* Some patches that introduce qmp interfaces talk of 'Since: 2.4',
  please revise to 2.5.
* Can you please go through the commit messages for formatting /
  grammar?  They're either too terse or lack some punctuation.  If you
  prefer, I can go through these and point these out as well.
* Similar to the previous point for some comments in-line as well, but
  I suppose those we could fix later.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]