Re: [Qemu-devel] [PATCH v7 21/42] postcopy: OS support test

[Dr. David Alan Gilbert]

* Amit Shah (address@hidden) wrote:
> On (Tue) 16 Jun 2015 [11:26:34], Dr. David Alan Gilbert (git) wrote:
> > From: "Dr. David Alan Gilbert" <address@hidden>
> > 
> > Provide a check to see if the OS we're running on has all the bits
> > needed for postcopy.
> > 
> > Creates postcopy-ram.c which will get most of the other helpers we need.
> > 
> > Signed-off-by: Dr. David Alan Gilbert <address@hidden>
> 
> > @@ -1165,6 +1166,10 @@ static int 
> > loadvm_postcopy_handle_advise(MigrationIncomingState *mis,
> >          return -1;
> >      }
> >  
> > +    if (!postcopy_ram_supported_by_host()) {
> > +        return -1;
> > +    }
> > +
> 
> So this is just advise: if we receive this, and we can't handle
> postcopy, we're going to abort migration?  Shouldn't we continue and
> let src know that we can't accept postcopy?  ie the problem is
> currently punted to higher levels, should we try to handle it
> ourselves?

We could, although it happens right at the start of migration, and it only
happens if you explicitly enabled the postcopy capability, so I'm not
sure there's any advantage in trying to fall back when you've been told
to use it.

Dave

> 
> 
> 
>               Amit
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK