Re: [Qemu-devel] [PATCH v4 2/2] QOM: object_property_add() performance improvement

[Pavel Fedin]

 Hello!

> I'm just asking myself whether this is really necessary.  Is the
> automagic [*] really needed in this case?  

 In this particular case, perhaps, not. However, this automagic is used not 
only with GPIOs. It is used also with memory regions, as well as with some 
other places. Also, i thought that there could be some hard to notice problems, 
when, for example, we first add unnamed-gpio-in[0...1023], then add another 
1024 pins, where count again goes from 0 to 1023. And we would get collision 
and failure, unless we know, that we already have 1024 objects with this name. 
So, just for better safety, i decided to fix the mechanism itself instead of 
changing use cases.

Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia