Re: [Qemu-devel] [PULL v3 00/12] Final changes for 2.4-rc0

[Peter Maydell]

On 24 July 2015 at 14:55, Paolo Bonzini <address@hidden> wrote:
>
>
> On 24/07/2015 15:31, Peter Maydell wrote:
>> Yes, but the set of required static libs for linux-user is pretty
>> tiny, and it doesn't generally change. In particular since we
>> don't want to link gnutls into linux-user we shouldn't be requiring
>> the user to scrape up a static lib of it to keep things working.
>> Requiring gnutls at all for these configure options is just a bug
>> (in configure or the makefile).
>
> Can you check if this works?
>
> diff --git a/Makefile.objs b/Makefile.objs
> index f094eff..9d988d9 100644
> --- a/Makefile.objs
> +++ b/Makefile.objs
> @@ -2,7 +2,9 @@
>  # Common libraries for tools and emulators
>  stub-obj-y = stubs/
>  util-obj-y = util/ qobject/ qapi/ qapi-types.o qapi-visit.o qapi-event.o
> -util-obj-y += crypto/
> +
> +util-obj-$(call notempty,$(TOOLS)) += crypto/
> +util-obj-$(CONFIG_SOFTMMU) += crypto/

Unfortunately not -- we still try to build socket_scm_helper,
and it still fails with:
  LINK  tests/qemu-iotests/socket_scm_helper
c++: error: unrecognized command line option ‘-R’

The fix will need to be to either
(a) make sure we don't try to link anything which
links with LIBS_TOOLS, or
(b) make sure configure doesn't put the results of
'pkg-config --libs --static gnutls' into compiler commandlines
(it is:
-R/usr/lib/x86_64-linux-gnu -lgnutls -lgcrypt -lgpg-error -ltasn1 -lz -lp11-kit
and that -R is a linker option, not a compiler option, I think.
But of course we use the compiler to do all our linking...)

thanks
-- PMM