[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/2] block: warn about aio=native if libaio i
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v2 0/2] block: warn about aio=native if libaio is unavailable |
Date: |
Thu, 23 Jul 2015 10:03:32 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Stefan Hajnoczi <address@hidden> writes:
> v2:
> * Banish CONFIG_LINUX_AIO from blockdev.c, that is raw-posix.c's business
> [Kevin]
> * Print the warning in the same way as the aio=native,cache.direct=off
> deprecation warning [Kevin]
>
> Open question: what about the Windows case? We now pass the
> FILE_FLAG_OVERLAPPED flag which we didn't do before for -drive aio=native.
Odd. Commit a273652 takes the trouble to implement native asynchronous
I/O there, but unless CONFIG_LINUX_AIO somehow gets defined, it's
unreachable, isn't it? Paolo?
I think PATCH 2's commit message needs to be updated to discuss the
impact.