[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH RFC v2 10/47] qapi-visit: Fix two name arguments

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH RFC v2 10/47] qapi-visit: Fix two name arguments passed to visitors
Date: Mon, 20 Jul 2015 20:26:36 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0

On 07/01/2015 02:21 PM, Markus Armbruster wrote:
> The generated code passes mangled schema names to visit_type_enum()
> and union's visit_start_struct().  Fix it to pass the names
> unadulterated, like we do everywhere else.
> Only qapi-schema-test.json actually has names where this makes a
> difference: enum __org.qemu_x-Enum, flat union __org.qemu_x-Union2,
> simple union __org.qemu_x-Union1 and its implicit enum
> __org.qemu_x-Union1Kind.

I'm glad I added that test - it covers things that will affect
downstream extensions, but which don't affect mainline.

> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  scripts/qapi-visit.py | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]